Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for N nginx ingresses per service #1

Merged
merged 8 commits into from
Jun 30, 2022
Merged

feat: add support for N nginx ingresses per service #1

merged 8 commits into from
Jun 30, 2022

Conversation

tperdue321
Copy link

This addresses Rally's need to support multiple stable ingresses per rollout in argo rollouts.

An issue against the primary repo has been made but not a lot of feedback on it.
argoproj#2001

Modifications:

  • update the Nginx datatype to have a field called AdditionalStableIngresses to allow for 1-N stable ingresses instead of just 1.
  • modify the SetWeight method to create a canary for each stable ingress and apply new weight to all canary ingresses.
  • update validations to validate all stable ingresses.
  • designed to be fully backwards compatible

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

tperdue321 and others added 8 commits June 22, 2022 10:36
@tperdue321
add additionalStableIngresses datatype
1d0f9cf 
Signed-off-by: Travis Perdue <[email protected]>
@tperdue321
add validation for additionalStableIngresses
22845f2 
Signed-off-by: Travis Perdue <[email protected]>
@tperdue321
add rollout controller logic for additionalStableIngresses
066ed1e 
Signed-off-by: Travis Perdue <[email protected]>
@tperdue321
add nginx ingress logic for setting weight & fetching names for addit…
e302429 
…ionalStableIngresses

Signed-off-by: Travis Perdue <[email protected]>
@tperdue321
add nginx testing for additionalStableIngresses
31eb2e4 
Signed-off-by: Travis Perdue <[email protected]>
add ingress & controller tests for additionalStableIngresses
56880f0 
Signed-off-by: Travis Perdue <[email protected]>
remove validation_references_test.go snafu
1c45c18 
Signed-off-by: Travis Perdue <[email protected]>
add ingress util testing for additionalStableIngresses
427576c 
Signed-off-by: Travis Perdue <[email protected]>
@tperdue321 tperdue321 merged commit ca45cf5 into master Jun 30, 2022
@ssanders1449
Copy link

Travis - This is exactly the feature we need for one of our products. Thanks for the effort.
Have you tried to get this merged into the master? I will try to push it with the community

@ssanders1449 ssanders1449 mentioned this pull request Aug 28, 2022
Closed
@tperdue321 tperdue321 deleted the feature-additional-nginx-ingresses branch August 30, 2022 16:34
@n888 n888 mentioned this pull request Dec 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrally tyrally tyrally approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tperdue321 @ssanders1449 @tyrally